Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place upper bound in cryptography indirect dependency #429

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 5, 2022

Fixes #424

@sbidoul
Copy link
Member Author

sbidoul commented Oct 5, 2022

runboat is green @CRogos

@CRogos
Copy link
Contributor

CRogos commented Oct 5, 2022

Have you tested that pysaml2 is working with cryptography < 3.1?
Otherwise it would be best to limit pysaml2 to version < 7.2 and not limit cryptography.

IdentityPython/pysaml2@v7.1.2...v7.2.0

@sbidoul
Copy link
Member Author

sbidoul commented Oct 5, 2022

Otherwise it would be best to limit pysaml2 to version < 7.2 and not limit cryptography.

Why? In this case installing pysaml2 cryptography<37 yields cryptography 36, so this should be fine?
I'm not using auth_saml though so I can't tell for sure.

@CRogos
Copy link
Contributor

CRogos commented Oct 5, 2022

Because with the update of pysaml2 7.1.2 -> 7.2.0 the dependency was changed:
image

There might be a reason?

Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the change fixes the build issue.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 5, 2022

Have you tested that pysaml2 is working with cryptography < 3.1?
Otherwise it would be best to limit pysaml2 to version < 7.2 and not limit cryptography.

In any case this should be a question for auth_saml users and maintainers.

/ocabot merge patch

@CRogos
Copy link
Contributor

CRogos commented Oct 5, 2022

@sbidoul I agree. Thank you, for your support. I've learned a lot.

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-429-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4fd5c42. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants